Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative logs #24

Merged
merged 3 commits into from
Dec 13, 2024
Merged

More informative logs #24

merged 3 commits into from
Dec 13, 2024

Conversation

slinkydeveloper
Copy link
Collaborator

Fix #22

@gvdongen only the first commit is relevant for the logs

Copy link

@gvdongen gvdongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions. Besides that it looks good to me.

src/vm/mod.rs Outdated Show resolved Hide resolved
src/vm/mod.rs Outdated Show resolved Hide resolved
src/vm/mod.rs Outdated Show resolved Hide resolved
src/vm/mod.rs Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper force-pushed the issues/22 branch 3 times, most recently from 4694e77 to f7d450f Compare December 13, 2024 16:27
@slinkydeveloper slinkydeveloper merged commit 0a45d53 into main Dec 13, 2024
4 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/22 branch December 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nice looking logging in debug mode, move the rest of the logging to trace
3 participants