Vendoring DelayQueue to enable customizations #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 7 files ±0 7 suites ±0 3m 17s ⏱️ +7s For more details on these errors, see this check. Results for commit b8a5018. ± Comparison against base commit c05c1de. ♻️ This comment has been updated with latest results. |
tillrohrmann
approved these changes
Nov 26, 2025
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Assuming that this PR copies the DelayQueue over w/o applying changes, then the PR looks good to me. +1 for merging :-)
Comment on lines
+1
to
+2
| // Based on a copy of DelayQueue from tokio-util | ||
| // https://github.com/tokio-rs/tokio/tree/4714ca168d6bd97193625657b0381e9b65a9ceff/tokio-util/src/time |
Contributor
There was a problem hiding this comment.
Did you apply any changes to the copy? If not, then I would skip the detailed review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.