Skip to content

Remove unused PartitionProcessorRpcError::Busy #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused PartitionProcessorRpcError::Busy #3863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/core/src/worker_api/partition_processor_rpc_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ impl From<PartitionProcessorRpcError> for RpcErrorKind {
match value {
PartitionProcessorRpcError::NotLeader(_) => RpcErrorKind::NotLeader,
PartitionProcessorRpcError::LostLeadership(_) => RpcErrorKind::LostLeadership,
PartitionProcessorRpcError::Busy => RpcErrorKind::Busy,
PartitionProcessorRpcError::Internal(msg) => RpcErrorKind::Internal(msg),
PartitionProcessorRpcError::Starting => RpcErrorKind::Starting,
PartitionProcessorRpcError::Stopping => RpcErrorKind::Stopping,
Expand Down
8 changes: 3 additions & 5 deletions crates/types/src/net/partition_processor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,9 @@ pub enum PartitionProcessorRpcError {
NotLeader(PartitionId),
#[error("not leader anymore for partition '{0}'")]
LostLeadership(PartitionId),
// todo: remove in 1.5
#[error("rejecting rpc because too busy")]
// #[deprecated(since = "1.4.0", note = "retained for backwards compatibility with <= 1.3.2 nodes, remove in 1.5")]
Busy,
// Removed in 1.6.0. Kept here to prevent reintroduction at a later point.
//#[error("rejecting rpc because too busy")]
//Busy,
#[error("internal error: {0}")]
Internal(String),
#[error("partition processor starting")]
Expand All @@ -149,7 +148,6 @@ impl PartitionProcessorRpcError {
PartitionProcessorRpcError::NotLeader(_) => true,
PartitionProcessorRpcError::LostLeadership(_) => true,
PartitionProcessorRpcError::Stopping => true,
PartitionProcessorRpcError::Busy => false,
PartitionProcessorRpcError::Internal(_) => false,
PartitionProcessorRpcError::Starting => false,
}
Expand Down
Loading