Consistent schema across partitions #3860
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary - add a dedicated metadata slot and read/write helpers for storing service schemas in the partition-store FSM table - extend the storage-api FSM table traits with schema accessors so callers can persist schema metadata
Summary: This PR make sure that PPs have a consistent service schema by writing and upsert-schema record to bifrost. The leader processor makes sure to write this record to bifrost when schema changes are detected
muhamadazmy
commented
Oct 3, 2025
| self.record_keys().matches_key_query(query) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is currently not used (and will never be) a new draft for envelope redesign can be checked here
|
Can we wait to merge this? |
|
@slinkydeveloper of course. Not urgent. let's discuss how we going to maintain the schema type. moving forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent schema across partitions
Summary:
This PR make sure that PPs have a consistent service schema by writing
and upsert-schema record to bifrost. The leader processor makes sure
to write this record to bifrost when schema changes are detected
Stack created with Sapling. Best reviewed with ReviewStack.