WIP, a full non-working implementation for delete-range-cf, blocked on WBWI #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a crate for time utilities (`serde-time-util`). The crate currently provides a trait `DurationExt` which provides a `friendly()` method for formatting a `Duration` as a human-readable string. It also allows parsing a human-friendly duration into a string. Additionally, this removes the helpers from `DurationString` and keeps `restate-serde-util`'s DurationString as a serialization helper only. Minor but relevant changes: - Some debug traces that reported the response latency now use the `to_seconds_span()` since it's cheaper to compute. - Fixed typos in restate CLI service config commands - More efficient serialization for DurationString that avoids an extra String allocation. - Used jiff's native span rounding feature to round a duration to "days" instead of the manual calculation. - Added a `negated()` method to the time span types to support "ago" formatting. - Migrateed all uses of `DurationString` to `DurationExt::friendly()` including in CLI argument parsing.
This was referenced Sep 4, 2025
Test Results 7 files ±0 7 suites ±0 4m 0s ⏱️ +17s For more details on these failures, see this check. Results for commit dbfeebc. ± Comparison against base commit 358a3e8. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.
Durationfor friendly display #3738