Slightly improved serialization size estimation #3629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
commented
Aug 6, 2025
|
|
||
| pub fn encode_as_bilrost<T: bilrost::Message>(value: &T) -> Bytes { | ||
| let buf = value.encode_fast(); | ||
| let buf = value.encode_contiguous(); |
There was a problem hiding this comment.
This is to ensure that into_vec() and Bytes::from() are zero-cost operations.
This was referenced Aug 6, 2025
This has been causing memory leak if it's set to zero so we are removing and it can be later re-introduced if its underlying issues are fixed.
muhamadazmy
approved these changes
Aug 6, 2025
| Ok(()) | ||
| } | ||
|
|
||
| fn estimate_json_serde_len<T: Serialize>(value: &T) -> Result<usize, serde_json::error::Error> { |
There was a problem hiding this comment.
Wouldn't this make calculating the estimate_size as inefficient as actually serialising the type (plus the buf allocations).
In other words, how is that better than just serialising the value directly without knowing the size estimate before hand.
There was a problem hiding this comment.
it's not really serializing, it's just performing all the visits needed to serialize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.