Skip to content

Minor update on metadata error messages #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Minor update on metadata error messages #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28c7dbb
TRestMetadata. SetWarning/Error now only registers the last warning/e…
jgalan Jul 3, 2023
00e39b5
TRestThread. Improving output message
jgalan Jul 3, 2023
0299bff
TRestMetadata::SetWarning fixing compilation issue
jgalan Jul 3, 2023
129b902
Merge branch 'master' into jgalan_errors
jgalan Jul 6, 2023
4355f58
Merge branch 'master' into jgalan_errors
jgalan Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions source/framework/core/src/TRestMetadata.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2630,18 +2630,23 @@ void TRestMetadata::SetError(string message, bool print) {
fError = true;
fNErrors++;
if (message != "") {
fErrorMessage += message + "\n";
// We keep only the last error message
fErrorMessage = message + "\n";
if (print) {
cout << message << endl;
}
}
}

///////////////////////////////////////////////
/// \brief It retrieves a map of all parameter:value found in the metadata class
///
void TRestMetadata::SetWarning(string message, bool print) {
fWarning = true;
fNWarnings++;
if (message != "") {
fWarningMessage += message + "\n";
// We keep only the last warning message
fWarningMessage = message + "\n";
if (print) {
RESTWarning << message << RESTendl;
}
Expand Down
14 changes: 11 additions & 3 deletions source/framework/core/src/TRestThread.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,13 +585,21 @@ void TRestThread::EndProcess() {
if (fProcessChain[i]->GetWarning()) nWarnings++;
}

if (nWarnings)
if (nWarnings) {
RESTWarning << nWarnings
<< " process warnings were found! Use run0->PrintWarnings(); to get additional info."
<< " process warnings were found! Check them inside the generated root file: "
<< RESTendl;
if (nErrors)
RESTWarning << "restRoot output.root" << RESTendl;
RESTWarning << "[0] run->PrintWarnings(); to get additional info." << RESTendl;
}
if (nErrors) {
RESTError << nErrors << " process errors were found! Use run0->PrintErrors(); to get additional info."
<< RESTendl;
RESTError << nErrors
<< " process errors were found! Check them inside the generated root file: " << RESTendl;
RESTError << "restRoot output.root" << RESTendl;
RESTError << "[0] run->PrintErrors(); to get additional info." << RESTendl;
}

delete fAnalysisTree;
}