Adding a method to uncompress a gzipped std::string #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanangp
approved these changes
Nov 29, 2023
lobis
reviewed
Nov 29, 2023
| static std::string POSTRequest(const std::string& url, const std::map<std::string, std::string>& keys); | ||
| static void ChangeDirectory(const std::string& toDirectory); | ||
|
|
||
| static bool GzipInflate(const std::string& compressedBytes, std::string& uncompressedBytes); |
There was a problem hiding this comment.
I think we should avoid passing mutable references and instead use the method's return. One strong reason to avoid doing so is that these functions are much more difficult to call from the python bindings (it's possible but much more complicated as just passing python objects as strings and so on).
lobis
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used right now, but I found it might be potentially used, so it is perhaps good to have it in the list of
TRestToolsmethods.