Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya
So the CI can't pass because it's set to use ubuntu-latest, which resolves to 24.04 right now, while some jobs can only work with 22.04, like the ones for jruby 9.2.
Explicitly using ubuntu 22.04 resolves the issue, though it's only temporary: eventually github will drop this version, likely at the end of its security maintenance window, which is april 2027; at that point, you'll probably have to drop support for older ruby and jruby versions.
Not sure what's up with jruby in the CI right now, seems stuck for random combinations of jruby and redis, maybe it's flaky?
As for
logger, it's because of this: https://github.com/resque/redis-namespace/actions/runs/21133265090/job/60769196203?pr=238The issue was hidden because the CI wouldn't even get to that point before.
Cheers!