fix add_namespace methods in case of nested array args#109
Open
lastcat wants to merge 1 commit intoresque:masterfrom
Open
fix add_namespace methods in case of nested array args#109lastcat wants to merge 1 commit intoresque:masterfrom
lastcat wants to merge 1 commit intoresque:masterfrom
Conversation
remove binding.pry
517a17c to
7722b5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis_namespace unsupported
hmsetof array args.ex:
output is
The unexpected behavior reason why is that
add_namespacemethod is not considered about nested array args. But redis-rb gem support it. I think interface between these gems are same is better, so added flatten process for nested array args. It is confirmed that this change is to pass all tests.