some logging and assertions we added for antithesis tests #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests" (#…" This reverts commit 7ff8d69.
agavra
approved these changes
Jul 2, 2024
Contributor
agavra
left a comment
agavra
left a comment
There was a problem hiding this comment.
some suggestions for improved logging
| private void maybeBackOffEnqueuingNewEventWithKey(final KIn key) { | ||
| while (schedulingQueue.keyQueueIsFull(key)) { | ||
| // TODO: switch to a periodic log | ||
| log.debug("key queue is full. back off until there is room on key queue"); |
Contributor
There was a problem hiding this comment.
nit: let's log which key is backing off, size of queue and back off time (if that's easily accessible)
| log.info("Cancelling {} pending records for {}[{}]", | ||
| inFlightForTask.size(), processorName, partition); | ||
| if (!inFlightForTask.isEmpty()) { | ||
| log.info("ANTITHESIS SOMETIMES: cancelling {} pending records for {}[{}]", |
Contributor
There was a problem hiding this comment.
is ANTITHESIS SOMETIMES a pragma?
|
|
||
| int size(); | ||
|
|
||
| int blockedEntries(); |
|
|
||
| public void flush(final long consumedOffset) { | ||
| if (consumedOffset < lastFlushedOffset) { | ||
| log.error("trying to commit an offset {} older than last flushed {}", |
Contributor
There was a problem hiding this comment.
when can this happen? Can we make this error message more actionable (or is it safe to ignore/just got fenced?)
| + "for this topic partition (%s)", threadId, topicPartition)); | ||
| } | ||
| if (storesForThread.size() > 1) { | ||
| LOGGER.warn("found more than 1 registration: {}", |
Contributor
There was a problem hiding this comment.
probably already in each registration but let's just add found more than 1 registration for {threadId}: {}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.