feat: introduce return value for updatePrice
to facilitate upkeep
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the keeper bot to update price ourselves as a last resort (after a period of unclaimed bounty), I realized one thing that needs improvement:
updatePrice
call, and then see if the receiving wallet indeed has received a rewardSo the proposed solution here is to add a return value such that:
Considerations
bool
, but decided that auint256
would be more useful for bots to ascertain the exact rewards applicableOther improvements