doc: update safety comment

reservoir-labs · Sep 13, 2024 · 9b2992c · 9b2992c
1 parent 2debe47
commit 9b2992c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/ReservoirPriceOracle.sol b/src/ReservoirPriceOracle.sol
@@ -164,7 +164,8 @@ contract ReservoirPriceOracle is IPriceOracle, Owned(msg.sender), ReentrancyGuar
             }
 
             _writePriceCache(lToken0, lToken1, lNewPrice);
-            // SAFETY: This will not overflow for, and hops are limited by `MAX_ROUTE_LENGTH`
+            // SAFETY: This will not overflow even if reward gas amount is set to the block gas limit (30M at time if writing),
+            // and hops are limited by `MAX_ROUTE_LENGTH`.
             unchecked {
                 rTotalReward += _calculateReward(lPrevPrice, lNewPrice, lRewardThreshold);
             }

diff --git a/test/unit/ReservoirPriceOracle.t.sol b/test/unit/ReservoirPriceOracle.t.sol
@@ -705,7 +705,7 @@ contract ReservoirPriceOracleTest is BaseTest {
         skip(_oracle.twapPeriod());
 
         lReward = _oracle.updatePrice(address(_tokenA), address(_tokenB), address(this));
-        assertGt(lReward, _oracle.rewardGasAmount() * 3); // ensure that rewards have accumulated
+        assertGt(lReward, _oracle.rewardGasAmount() * 3); // ensure that rewards have been aggregated across routes
     }
 
     function testSetRoute() public {