Skip to content

Commit

Permalink
remove resolved REVIEW
Browse files Browse the repository at this point in the history
  • Loading branch information
OliverNChalk committed Jul 7, 2024
1 parent 5b9523e commit 4880a37
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/ReservoirPriceOracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ contract ReservoirPriceOracle is IPriceOracle, IReservoirPriceOracle, Owned(msg.
_getRouteDecimalDifferencePrice(lToken0, lToken1);

if (lRoute.length == 0) {
// REVIEW: Is it possible for `aQuote` to be an IERC4626?
// There is one case where the behavior is a bit more unexpected, and that is when
// `aBase` is an empty contract, and the revert would not be caught at all, causing
// the entire operation to fail. But this is okay, because if `aBase` is not a contract, trying
Expand Down

0 comments on commit 4880a37

Please sign in to comment.