Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ABDK audit findings #241

Merged
merged 53 commits into from
Jan 27, 2025
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
707e270
fix: move `safeApprove` out of `_doDivest`
xenide Dec 29, 2024
bc024be
fix: #5
xenide Dec 29, 2024
e880dfe
fix: #14
xenide Dec 30, 2024
af0178e
fix: #13
xenide Dec 30, 2024
6e670dd
lint: fix issues
xenide Dec 31, 2024
1364ae1
fix: #16
xenide Dec 31, 2024
d38a82e
fix: #34
xenide Dec 31, 2024
ddec60b
fix: #35
xenide Dec 31, 2024
98d1648
fix: #36
xenide Dec 31, 2024
df975da
fix: #37
xenide Dec 31, 2024
3596ae0
docs: format comment
xenide Dec 31, 2024
7480072
fix: #12
xenide Dec 31, 2024
928ef07
fix: returnAsset usage formatting
xenide Dec 31, 2024
e256b39
fix: follow up to #2
xenide Dec 31, 2024
4c89fa9
ci: update hashes
xenide Dec 31, 2024
8ab575e
fix: #6
xenide Dec 31, 2024
b16f55f
fix: #8
xenide Dec 31, 2024
433b72a
fix: #46
xenide Dec 31, 2024
b4e95a9
fix: #45
xenide Dec 31, 2024
d00254a
fix: #29
xenide Dec 31, 2024
4283a1d
fix: #30
xenide Dec 31, 2024
8338d60
fix: #28
xenide Dec 31, 2024
64119fd
fix: #27
xenide Jan 1, 2025
0a21273
fix: #22
xenide Jan 1, 2025
83a4f2a
fix: #21
xenide Jan 1, 2025
e527b72
fix: #26
xenide Jan 1, 2025
94890e3
fix: #7
xenide Jan 1, 2025
2a6f1b8
fix: #31
xenide Jan 1, 2025
f6a4574
fix: use custom errors for asset manager
xenide Jan 1, 2025
35df5ed
test: update event name
xenide Jan 1, 2025
d60f747
fix: #44
xenide Jan 1, 2025
d32abff
fix: #43
xenide Jan 1, 2025
43c8424
ci: update hashes
xenide Jan 1, 2025
08a71fd
lint: solhint disable line for test file
xenide Jan 3, 2025
eef6e77
gas: update snapshot
xenide Jan 3, 2025
3b359d3
fix: rm unnecessary casting
xenide Jan 8, 2025
1a76a6f
fix: rm fix for #44
xenide Jan 8, 2025
1732564
ci: update hash
xenide Jan 8, 2025
19a8653
fix: use `unchecked` at safe places and custom errors to reduce bytec…
xenide Jan 9, 2025
2293b6b
fix: custom errors everywhere
xenide Jan 10, 2025
bc04ec3
ci: update hashes
xenide Jan 10, 2025
d8f1ea2
lib: update forge-std
xenide Jan 10, 2025
12c41f5
ci: use stable foundry release
xenide Jan 10, 2025
afd8117
ci: specify foundry toolchain version
xenide Jan 10, 2025
e08bb7c
ci: temporarily setting bytecode hash to none
xenide Jan 10, 2025
b7922c6
ci: update hashes
xenide Jan 10, 2025
62d5735
chore: upgrade .nvmrc to use lts
xenide Jan 13, 2025
d9e9489
test: add base case for adjustManagement so that it succeeds even for…
xenide Jan 22, 2025
bd82ae6
fix: use try catch when calling afterLiquidityEvent
xenide Jan 23, 2025
43f59d4
ci: update hash
xenide Jan 24, 2025
640ba2d
gas: update snapshot
xenide Jan 24, 2025
8228b16
feat: emit event for afterLiquidityEvent failure
xenide Jan 24, 2025
e3a339e
gas: update snapshot
xenide Jan 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: #45
xenide committed Dec 31, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b4e95a93d514ab3f123b6dce60183a43deab8b20
4 changes: 2 additions & 2 deletions src/ReservoirPair.sol
Original file line number Diff line number Diff line change
@@ -477,7 +477,7 @@ abstract contract ReservoirPair is IAssetManagedPair, ReservoirERC20, RGT {

//////////////////////////////////////////////////////////////////////////*/

event ClampParamsUpdated(uint128 newMaxChangeRatePerSecond, uint128 newMaxChangePerTrade);
event ClampParams(uint128 newMaxChangeRatePerSecond, uint128 newMaxChangePerTrade);

// 1% per second which is 60% per minute
uint256 internal constant MAX_CHANGE_PER_SEC = 0.01e18;
@@ -502,7 +502,7 @@ abstract contract ReservoirPair is IAssetManagedPair, ReservoirERC20, RGT {
require(0 < aMaxChangeRate && aMaxChangeRate <= MAX_CHANGE_PER_SEC, InvalidChangePerSecond());
require(0 < aMaxChangePerTrade && aMaxChangePerTrade <= MAX_CHANGE_PER_TRADE, InvalidChangePerTrade());

emit ClampParamsUpdated(aMaxChangeRate, aMaxChangePerTrade);
emit ClampParams(aMaxChangeRate, aMaxChangePerTrade);
maxChangeRate = aMaxChangeRate;
maxChangePerTrade = aMaxChangePerTrade;
}