feat: use mapping instead of array for oracle observations #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenide
changed the title
OliverNChalk
approved these changes
Jan 22, 2024
xenide
force-pushed
the
feat/use-mapping-over-array
branch
from
f7784a2 to
89ba783
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #221 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 12 12
Lines 623 623
=======================================
Hits 425 425
Misses 198 198 ☔ View full report in Codecov by Sentry. |
xenide
commented
Jan 23, 2024
| @@ -924,7 +924,7 @@ contract StablePairTest is BaseTest { | |||
| bytes32 lEncoded = bytes32(abi.encodePacked(lLastInvariantAmp, lLastInvariant)); | |||
| // hardcoding the slot for now as there is no way to access it publicly | |||
| // this will break when we change the storage layout | |||
| vm.store(address(_stablePair), bytes32(uint256(65_553)), lEncoded); | |||
| vm.store(address(_stablePair), bytes32(uint256(18)), lEncoded); | |||
There was a problem hiding this comment.
had to change the storage slot as the storage layout has changed cuz we're no longer using an array for _observations
xenide
force-pushed
the
feat/use-mapping-over-array
branch
2 times, most recently
from
f292008 to
96520d1
Compare
xenide
force-pushed
the
feat/use-mapping-over-array
branch
from
96520d1 to
99cf211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
uint16as the input type instead ofuint256. But the gas changes are a mixed bag. Therefore not proceeding with that change