Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#379 Remove deprecated property use #390

Merged
merged 4 commits into from
Jul 8, 2024
Merged

#379 Remove deprecated property use #390

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
020c53c
Remove deprecated property use
IRus May 13, 2024
cd1177a
Merge branch 'researchgate:main' into main
IRus Jul 8, 2024
de5ca59
Add Gradle version check to prevent usage of deprecated settingsFile …
IRus Jul 8, 2024
1a63261
Add Gradle version check to prevent usage of deprecated settingsFile …
IRus Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/groovy/net/researchgate/release/ReleasePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import org.gradle.api.Task
import org.gradle.api.plugins.BasePlugin
import org.gradle.api.tasks.GradleBuild
import org.gradle.api.tasks.TaskState
import org.gradle.util.GradleVersion

class ReleasePlugin extends PluginHelper implements Plugin<Project> {

Expand Down Expand Up @@ -104,7 +105,10 @@ class ReleasePlugin extends PluginHelper implements Plugin<Project> {
startParameter.projectProperties.putAll(project.getGradle().startParameter.projectProperties)
startParameter.projectProperties.put('release.releasing', "true")
startParameter.projectDir = project.projectDir
startParameter.settingsFile = project.getGradle().startParameter.settingsFile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap this in an if that checks the gradle version to not break existing usages of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hillkorn updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

if (GradleVersion.current() < GradleVersion.version("9.0")) {
// Setting custom settings file for the build has been deprecated.
startParameter.settingsFile = project.getGradle().startParameter.settingsFile
}
startParameter.gradleUserHomeDir = project.getGradle().startParameter.gradleUserHomeDir
buildName = project.name

Expand Down
Loading