Replace taskGraph.afterTask with an operation completion listener in …

…Gradle 6.1+
researchgate · Feb 20, 2024 · 7ffe081 · 7ffe081
1 parent af4bf46
commit 7ffe081
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 13 deletions.
diff --git a/build.gradle b/build.gradle
@@ -1,3 +1,5 @@
+import org.gradle.api.internal.classpath.ModuleRegistry
+
 buildscript {
     repositories {
         maven {
@@ -33,6 +35,10 @@ dependencies {
     testCompile "cglib:cglib-nodep:3.2.8"
     testImplementation gradleTestKit()
     testImplementation("org.junit.jupiter:junit-jupiter:5.7.1")
+
+    // work-around for https://github.com/gradle/gradle/issues/16774
+    testRuntimeOnly(files(project.services.get(ModuleRegistry).getModule('gradle-tooling-api-builders').classpath.asFiles.first()))
+    testRuntimeOnly('com.google.guava:guava:27.1-android')
 }
 
 gradlePlugin {

diff --git a/src/main/groovy/net/researchgate/release/BuildEventsListenerRegistryProvider.groovy b/src/main/groovy/net/researchgate/release/BuildEventsListenerRegistryProvider.groovy
@@ -0,0 +1,10 @@
+package net.researchgate.release
+
+import org.gradle.build.event.BuildEventsListenerRegistry
+
+import javax.inject.Inject
+
+interface BuildEventsListenerRegistryProvider {
+   @Inject
+   BuildEventsListenerRegistry getBuildEventsListenerRegistry();
+}
diff --git a/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy b/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy
@@ -28,12 +28,19 @@ import org.gradle.api.GradleException
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.api.Task
+import org.gradle.api.model.ObjectFactory
 import org.gradle.api.plugins.BasePlugin
+import org.gradle.api.provider.ProviderFactory
 import org.gradle.api.tasks.GradleBuild
 import org.gradle.api.tasks.TaskState
+import org.gradle.build.event.BuildEventsListenerRegistry
+import org.gradle.tooling.events.OperationCompletionListener
+import org.gradle.tooling.events.task.TaskFailureResult
+import org.gradle.util.GradleVersion
 
-class ReleasePlugin extends PluginHelper implements Plugin<Project> {
+import javax.inject.Inject
 
+abstract class ReleasePlugin extends PluginHelper implements Plugin<Project> {
     static final String RELEASE_GROUP = 'Release'
 
     private BaseScmAdapter scmAdapter
@@ -73,7 +80,7 @@ class ReleasePlugin extends PluginHelper implements Plugin<Project> {
                 "${p}updateVersion" as String,
                 "${p}commitNewVersion" as String
             ]
-            
+
             // Gradle 6 workaround (https://github.com/gradle/gradle/issues/12872)
             buildName = project.name + "-release"
         }
@@ -115,7 +122,7 @@ class ReleasePlugin extends PluginHelper implements Plugin<Project> {
                         "${p}afterReleaseBuild" as String
                 ].flatten()
             }
-            
+
             // Gradle 6 workaround (https://github.com/gradle/gradle/issues/12872)
             buildName = project.name + "-release"
         }
@@ -157,18 +164,40 @@ class ReleasePlugin extends PluginHelper implements Plugin<Project> {
             }
         }
 
-        project.gradle.taskGraph.afterTask { Task task, TaskState state ->
-            if (state.failure && task.name == "release") {
-                try {
-                    createScmAdapter()
-                } catch (Exception ignored) {}
-                if (scmAdapter && extension.revertOnFail && project.file(extension.versionPropertyFile)?.exists()) {
-                    log.error('Release process failed, reverting back any changes made by Release Plugin.')
-                    scmAdapter.revert()
-                } else {
-                    log.error('Release process failed, please remember to revert any uncommitted changes made by the Release Plugin.')
+        if (GradleVersion.current() < GradleVersion.version('6.1')) {
+            project.gradle.taskGraph.afterTask { Task task, TaskState state ->
+                if (state.failure && task.name == 'release') {
+                    revert()
                 }
             }
+        } else {
+            objects.newInstance(BuildEventsListenerRegistryProvider)
+                  .buildEventsListenerRegistry
+                  .onTaskCompletion(providers.provider {
+                      { finishEvent ->
+                          if ((finishEvent.result instanceof TaskFailureResult) && finishEvent.descriptor.taskPath.endsWith(':release')) {
+                              revert()
+                          }
+                      } as OperationCompletionListener
+                  })
+        }
+    }
+
+    @Inject
+    abstract protected ObjectFactory getObjects();
+
+    @Inject
+    abstract protected ProviderFactory getProviders();
+
+    protected revert() {
+        try {
+            createScmAdapter()
+        } catch (Exception ignored) {}
+        if (scmAdapter && extension.revertOnFail && project.file(extension.versionPropertyFile)?.exists()) {
+            log.error('Release process failed, reverting back any changes made by Release Plugin.')
+            scmAdapter.revert()
+        } else {
+            log.error('Release process failed, please remember to revert any uncommitted changes made by the Release Plugin.')
         }
     }