Repository navigation
Ship third-party license notices in the native platform packages - #8594
Conversation
3e4cda7 to
21709c8
Compare
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8594 |
21709c8 to
4a37e7d
Compare
Changelog💅 Polish
Semantic Diff1 commit · Full page Ship third-party license notices in the native platform packages9b0282f · cknitt + Claude · Nov 08, 2026, 20:08 UTC Each The generator takes the versions and license texts of OCaml libraries from the opam switch and asks dune which opam packages the shipped executables link, failing when the inventory misses one or lists one that is not linked. The files are committed; the linux-x64 build job checks them. |
✅ Compiler benchmarksAllocated wordsIn total: 456,989,425 → 456,989,425 (±0.00%). None of the 257 benchmarks changed by 0.1% or more. InstructionsIn total: 10,226,962,471 → 10,226,962,471 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Pull request 9b0282f compared with base d47adb3 in this run. |
023c15e to
3773646
Compare
3773646 to
9b0282f
Compare
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Each @rescript/<platform> package now ships a THIRD_PARTY_LICENSES file generated from licenses/components.json. It covers the vendored Flow, Sedlex and js_of_ocaml sources, the LexiFi-derived reanalyze code, every linked OCaml library, and the glibc and MinGW-w64 runtimes, which are linked statically. It replaces the rewatch-only THIRD_PARTY_NOTICES_REWATCH.md and RE_LICENSE.md. The generator takes the versions and license texts of OCaml libraries from the opam switch and asks dune which opam packages the shipped executables link, failing when the inventory misses one or lists one that is not linked. The files are committed; the linux-x64 build job checks them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLboTZTRoQAbXc4ZzC Signed-off-by: Christoph Knittel <ck@cca.io>
9b0282f to
a29b324
Compare
Changelog💅 Polish
Semantic Diff1 commit · Full page Ship third-party license notices in the native platform packagesa29b324 · cknitt + Claude · Nov 08, 2026, 20:08 UTC Each The generator takes the versions and license texts of OCaml libraries from the opam switch and asks dune which opam packages the shipped executables link, failing when the inventory misses one or lists one that is not linked. The files are committed; the linux-x64 build job checks them. |
✅ Compiler benchmarksAllocated wordsIn total: 683,221,231 → 683,220,947 (±0.00%). Generated projects: 923,208,001 → 923,209,226 (±0.00%). None of the 265 benchmarks changed by 0.1% or more. InstructionsIn total: 9,666,123,646 → 9,666,123,646 (±0.00%). None of the 33 benchmarks changed by 0.1% or more. Output sizeIn total: 25,841,785 → 25,841,785 (±0.00%). None of the 13 benchmarks changed by 0.1% or more. Pull request a29b324 compared with base e8ba9f9 in this run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8594 +/- ##
=======================================
Coverage 81.96% 81.97%
=======================================
Files 456 456
Lines 65613 65613
=======================================
+ Hits 53781 53783 +2
+ Misses 11832 11830 -2 🚀 New features to boost your workflow:
|
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8594 |
Each native platform package (
@rescript/<platform>) now ships aTHIRD_PARTY_LICENSESfile with the notices for the third-party software compiled into its binaries:Flow_map/Flow_setThe file replaces the hand-written
THIRD_PARTY_NOTICES_REWATCH.mdandRE_LICENSE.mdthat the OCaml build system added (#8780).scripts/generateThirdPartyLicenses.js(yarn licenses:generate) builds the files fromlicenses/components.json:opamfield. Their version and license text come from the opam switch:opam var <pkg>:versionand the license file inopam var <pkg>:doc. The libuv version is read from luv's installeduv/version.h. A dependency upgrade therefore needs no manual edits; regenerating is enough.dune describe workspacefrom the four shipped executables. It fails when a linked opam package is missing from the inventory, or when the inventory lists one that isn't linked. dune'srequiresincludes PPX runtime libraries but not the rewriters themselves.The files are committed. The linux-x64 build job checks them with
--checkagainst its switch, the one the release binaries come from.The Flow README is also corrected: the retained collection sources are now only the LGPL
Flow_map/Flow_set.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gLboTZTRoQAbXc4ZzC