Fix Parmatch crash on empty record head patterns#8246
Open
fhammerschmidt wants to merge 1 commit intorescript-lang:masterfrom
Open
Fix Parmatch crash on empty record head patterns#8246fhammerschmidt wants to merge 1 commit intorescript-lang:masterfrom
fhammerschmidt wants to merge 1 commit intorescript-lang:masterfrom
Conversation
fhammerschmidt
force-pushed
the
fix-parmatch-dict-error
branch
2 times, most recently
from
90d6464 to
f7af484
Compare
fhammerschmidt
force-pushed
the
fix-parmatch-dict-error
branch
from
f7af484 to
4103f47
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cristianoc
approved these changes
Feb 14, 2026
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Fix looks good.
A dedicated build test seems a little more overkill from something we just want to check compiles without crashing.
Easier to just add a 2-liner to tests/src
| body: Json(JSON.Object(dict{ | ||
| "request": JSON.String("READ"), | ||
| "payload": JSON.Object(dict{ | ||
| "list-a": JSON.Object(dict{"last_known_events": JSON.Object(dict{})}), |
Collaborator
There was a problem hiding this comment.
Nit: the empty dict is a little buried in this example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://forum.rescript-lang.org/t/compiler-crash-in-complex-test-file-fatal-error-parmatch-all-record-args/7124