Add optional message argument to Result.getOrThrow and improve default error message
#7630
+55
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
force-pushed
the
result-get-or-throw-message
branch
from
c36f3e7 to
013b234
Compare
mediremi
force-pushed
the
result-get-or-throw-message
branch
from
013b234 to
e4c07a3
Compare
zth
reviewed
Jul 11, 2025
Comment on lines
-29
to
+35
| | Error(_) => throw(Not_found) | ||
| | Error(_) => | ||
| Stdlib_JsError.panic( | ||
| switch message { | ||
| | None => "Result.getOrThrow called for Error value" | ||
| | Some(message) => message | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I guess technically this is a breaking change. But I don't think we've stopped because of this before (going from exception to general JS error).
There was a problem hiding this comment.
I've added a note to the changelog about this breaking change 👍
zth
approved these changes
Jul 11, 2025
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
|
Yes, please rebase @mediremi. |
|
@cknitt I've rebased and moved the changelog entries to be under |
nojaf
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
Not_foundthrown byResult.getOrThrowOptionandResultby adding an optionalmessageargument toResult.getOrThrow