Skip to content

Fix missing unescaping when accessing prop with exotic name #7469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Fix missing unescaping when accessing prop with exotic name #7469

merged 2 commits into from
May 14, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 13, 2025 •
edited
Loading

Fixes #7431

@cknitt cknitt requested review from zth and cristianoc May 13, 2025 15:11
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 13, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7469

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7469

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7469

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7469

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7469

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7469

commit: 2a79e32

cristianoc
cristianoc approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Wondering when this changed.

@cknitt cknitt merged commit a838193 into master May 14, 2025
21 checks passed
@cknitt cknitt deleted the fix-missing-unescaping branch May 14, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@zth zth Awaiting requested review from zth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing unescaping when accessing prop with exotic name
2 participants
@cknitt @cristianoc