Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot/live viewer to the dataframe view doc #7805

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Oct 17, 2024

What

Add a screenshot (and thus a live viewer) to the dataframe view generated docs

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-view Everything related to the dataframe view labels Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Deployed docs

Commit Link
efa4363 https://landing-ezggbl4je-rerun.vercel.app/docs

@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

@abey79 I just noticed the thumbnail is of a debug build

@abey79
Copy link
Member Author

abey79 commented Oct 17, 2024

Arf. I keep forgetting about that. updating.

@jleibs jleibs merged commit 9502846 into main Oct 17, 2024
30 checks passed
@jleibs jleibs deleted the antoine/dataframe-view-screenshot branch October 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-view Everything related to the dataframe view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants