Make sure to always write out end-of-stream markers during encoding #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/11381591566 |
teh-cmc
changed the title
teh-cmc
added
🪳 bug
|
I can confirm this fixes the |
emilk
approved these changes
Oct 17, 2024
| @@ -120,15 +179,20 @@ impl<W: std::io::Write> Encoder<W> { | |||
| } | |||
| } | |||
|
|
|||
| // NOTE: This cannot be done in a `Drop` implementation because of `Self::into_inner` which | |||
| // does a partial move. | |||
| #[inline] | |||
| pub fn finish(&mut self) -> Result<(), EncodeError> { | |||
| MessageHeader::EndOfStream.encode(&mut self.write)?; | |||
| Ok(()) | |||
There was a problem hiding this comment.
We could warn in Drop if this hasn't been called, at least in debug builds
There was a problem hiding this comment.
Not sure what you mean? We cannot implement Drop for Encoder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving Rerun RRD data can happen in many, many different ways, and it must always make sure to include the end-of-stream marker.
This is unfortunately not trivial because many things want to partial move out of
Encoder, which rules outimpl Drop.This PR introduces a
DroppableEncoderthat can be used in many cases, or makes sure to properlyfinish()otherwise.This fixes half of the issues described in:
rr.log_file_from_pathjust hangs indefinitely #7791Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.