Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rerun 3.9 compatibility: Remove imports of TypeAlias #7794

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix Rerun 3.9 compatibility: Remove imports of TypeAlias #7794

merged 3 commits into from
Oct 17, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 17, 2024 •
edited by github-actions bot
Loading

What

Checklist

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added the 🐍 Python API Python logging API label Oct 17, 2024
@emilk
Copy link
Member Author

emilk commented Oct 17, 2024

@rerun-bot full-check

@emilk emilk added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Oct 17, 2024
@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11381030749

emilk
emilk commented Oct 17, 2024
View reviewed changes
rerun_py/rerun_bindings/__init__.py
@@ -1,5 +1,3 @@
from __future__ import annotations

from typing import TYPE_CHECKING, TypeAlias, Union
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these were just unnecessary??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah. Why didn't Mypy warn about those?

@emilk emilk mentioned this pull request Oct 17, 2024
Merged
6 tasks
@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

Still showing issues:

>>> import rerun
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jleibs/py38/venv/lib/python3.8/site-packages/rerun_sdk/rerun/__init__.py", line 20, in <module>
    from . import (
  File "/home/jleibs/py38/venv/lib/python3.8/site-packages/rerun_sdk/rerun/dataframe.py", line 15, in <module>
    from rerun_bindings.types import (
  File "/home/jleibs/py38/venv/lib/python3.8/site-packages/rerun_bindings/types.py", line 37, in <module>
    ComponentLike: TypeAlias = Union[str, type["ComponentMixin"]]
TypeError: 'type' object is not subscriptable

@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11382023666

@jleibs
Copy link
Member

jleibs commented Oct 17, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11382665361

@jleibs jleibs merged commit d50e9e0 into main Oct 17, 2024
55 checks passed
@jleibs jleibs deleted the emilk/type-alias branch October 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We now require Python 3.10
2 participants
@emilk @jleibs