Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sysroot to 2.17 to ensure cpp builds are linking against correct libc #7792

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 17, 2024

What

As indicated by the lack of pixi.lock changes, this was already the case.
Making it explicit to avoid issues when removing dependencies & to hedge against copy&paste surprises.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 17, 2024
Copy link

Deployed docs

Commit Link
c8d9686 https://landing-12ljnfegn-rerun.vercel.app/docs

@Wumpf Wumpf merged commit f0e4076 into main Oct 17, 2024
42 checks passed
@Wumpf Wumpf deleted the andreas/pin-sysroot branch October 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants