Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable solid 3D boxes for nuscenes #7021

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Enable solid 3D boxes for nuscenes #7021

merged 2 commits into from
Jul 31, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 30, 2024 •
edited by github-actions bot
Loading

It looks soooo much better 😍

image

Also: pixi run format.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 30, 2024
Wumpf
Wumpf approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme has most of the rerun calls duplicated and needs to be updated as well :/

@github-actions GitHub Actions
Copy link

Deployed docs

Commit Link
253dd69 https://landing-7jiyym68o-rerun.vercel.app/docs

@teh-cmc teh-cmc merged commit 8d8dc76 into main Jul 31, 2024
29 of 30 checks passed
@teh-cmc teh-cmc deleted the cmc/nuscnes_solid branch July 31, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf