New transform components: Translation3D & TransformMat3x3
#6866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make transform3d translation & mat3x3 nullable
…sts more forward looking python fixup
…ul tests accordingly
Wumpf
added
🚜 refactor
Deployed docs
|
Wumpf
force-pushed
the
andreas/translation-and-transformmat3-components
branch
from
28105bb
to
7100140
Compare
…nd-transformmat3-components
…nd-transformmat3-components
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9937621641 |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9941007196 |
jleibs
approved these changes
Jul 15, 2024
Comment on lines
+12
to
+13
| /// E.g. if both a 4x4 matrix with a translation and a translation vector are present, | ||
| /// the matrix is applied first, then the translation vector on top. |
There was a problem hiding this comment.
We are more and more establishing an alternative pattern of elsewhere of "if X is set, then Y and Z are ignored, with a warning". I still wonder if this might be the better thing to do with mat4x4 and mat3x3+transform.
There was a problem hiding this comment.
not a bad point, but the exclusion sets are arguably more complicated than including everything 🤔
There was a problem hiding this comment.
exclusion sets are arguably more complicated than including everything
I agree with this. The new design is conceptually very simple: we have a bunch of different transform components, and we have a well-defined order in which they are applied.
Wumpf
added a commit
that referenced
this pull request
Jul 16, 2024
### What * Part of #6831 * Based on #6866 Introduces a new `Scale3D` component that lives directly on the `Transform3D` archetype. The `Scale3D` _datatype_ which is part of `TranslationRotationScale3D` is still around, but will be removed in a subsequent PR. Additionally, reversed order of how transform components. Rationale: "translation, rotation, scale" is a common way of expressing a simple transform. What is meant is that we first scale an object, then rotate it and _then_ translate it. Commit by commit review possible. ### Checklist * [x] pass `main` ci * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6892?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6892?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6892) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Starts the process of splitting up
Transform3Dinto several components.Far from done overall, but establishes a lot of the new documentation & test patterns for this effort.
This PR fully replaces the
TranslationAndMat3x3variant & datatype and putsTranslation3D&TransformMat3x3into existence and to work.It does not touch on anything directly related to out of tree transforms and does not do away from the
Transform3Dcomponent yet.I added a new component edit/view ui for consistency:
Checklist
mainci checksmainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.