Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 Support #6762

Open
Serafadam opened this issue Jul 4, 2024 · 4 comments
Open

Numpy 2.0 Support #6762

Serafadam opened this issue Jul 4, 2024 · 4 comments
Labels
dependencies concerning crates, pip packages etc enhancement New feature or request 🐍 Python API Python logging API

Comments

@Serafadam
Copy link

Is your feature request related to a problem? Please describe.
Currently Rerun pip install requires Numpy 1.x, which prevents installing when Numpy 2.0 is already installed and some parts like logging images break after installing rerun-sdk with lower version and later upgrading it.

Describe the solution you'd like
Adding support for Numpy 2.0

@Serafadam Serafadam added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 4, 2024
@emilk emilk added 🐍 Python API Python logging API and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 4, 2024
@emilk
Copy link
Member

emilk commented Jul 4, 2024

What is needed is a change to

"numpy>=1.23,<2",

…and testing

@Wumpf Wumpf mentioned this issue Jul 19, 2024
@Wumpf
Copy link
Member

Wumpf commented Jul 19, 2024

Via #6948:

Numpy 2.0 has been out for a bit now and is starting to show up as a real dep in more projects.

See: https://numpy.org/devdocs/numpy_2_0_migration_guide.html

Historically we had to limit ourselves to < 2.0 because of:

However, I don't believe we depend on numpy bindings through PyO3 at this point so we may be able to relax our dep.

@Wumpf Wumpf added the dependencies concerning crates, pip packages etc label Jul 19, 2024
@preston-thomson-dedrone
Copy link

@Wumpf Are you guys likely to update to the latest version of numpy in the next release?

@Wumpf
Copy link
Member

Wumpf commented Oct 3, 2024

@preston-thomson-dedrone no we didn't get to this one so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc enhancement New feature or request 🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

4 participants