Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use an octahedron as the subdivision shape for
ProcMeshKey::Sphere
. (…
…#7014) ### What Instead of an icosahedron, use an octahedron. The edges of the octahedron become axis-aligned great circles around the subdivided mesh, which makes more sense for ellipsoid visualization since the axes and their perpendicular planes are significant. ![Screenshot 2024-07-29 at 15 13 53](https://github.com/user-attachments/assets/4c4d90f8-f590-4949-8e84-1102ab2c17e3) This will make it easy to also choose to draw *only* the axis-aligned great circles (once OptimisticPeach/hexasphere#26 is available), making this a step towards implementing #6962. ### Checklist * [X] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [X] I've included a screenshot or gif (if applicable) * [ ] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7014?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7014?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [X] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [X] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [X] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7014) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information