remove disable asan again

rerun-io · Mar 18, 2024 · 051dd08 · 051dd08
1 parent 2ae3fb1
commit 051dd08
Show file tree

Hide file tree

Showing 42 changed files with 42 additions and 107 deletions.
diff --git a/crates/re_types_builder/src/codegen/cpp/mod.rs b/crates/re_types_builder/src/codegen/cpp/mod.rs
@@ -1384,20 +1384,12 @@ fn arrow_data_type_method(
             return datatype;
         }
     };
-    let return_type = if is_forwarding {
-        // Disable asan since we got rather strange spurious ci failure on Linux with these methods:
-        // Some Linux runs end up spamming `AddressSanitizer:DEADLYSIGNAL` indefinitely with no additional information.1
-        hpp_includes.insert_rerun("compiler_utils.hpp"); // RR_DISABLE_ASAN
-        quote! { RR_DISABLE_ASAN const std::shared_ptr<arrow::DataType>& }
-    } else {
-        quote! { const std::shared_ptr<arrow::DataType>& }
-    };
 
     Method {
         docs: "Returns the arrow data type this type corresponds to.".into(),
         declaration: MethodDeclaration {
             is_static: true,
-            return_type,
+            return_type: quote! { const std::shared_ptr<arrow::DataType>& },
             name_and_parameters: quote! { arrow_datatype() },
         },
         definition_body,
@@ -1501,14 +1493,6 @@ fn to_arrow_method(
             return array;
         }
     };
-    let return_type = if is_forwarding {
-        // Disable asan since we got rather strange spurious ci failure on Linux with these methods:
-        // Some Linux runs end up spamming `AddressSanitizer:DEADLYSIGNAL` indefinitely with no additional information.1
-        hpp_includes.insert_rerun("compiler_utils.hpp"); // RR_DISABLE_ASAN
-        quote! { RR_DISABLE_ASAN Result<std::shared_ptr<arrow::Array>> }
-    } else {
-        quote! { Result<std::shared_ptr<arrow::Array>> }
-    };
 
     Method {
         docs: format!(
@@ -1517,7 +1501,7 @@ fn to_arrow_method(
         .into(),
         declaration: MethodDeclaration {
             is_static: true,
-            return_type,
+            return_type: quote! { Result<std::shared_ptr<arrow::Array>> },
             name_and_parameters: quote! {
                 to_arrow(const #quoted_namespace::#type_ident* instances, size_t num_instances)
             },

diff --git a/rerun_cpp/src/rerun/blueprint/components/active_tab.hpp b/rerun_cpp/src/rerun/blueprint/components/active_tab.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/included_content.hpp b/rerun_cpp/src/rerun/blueprint/components/included_content.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/included_space_view.hpp b/rerun_cpp/src/rerun/blueprint/components/included_space_view.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/panel_expanded.hpp b/rerun_cpp/src/rerun/blueprint/components/panel_expanded.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/query_expression.hpp b/rerun_cpp/src/rerun/blueprint/components/query_expression.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/root_container.hpp b/rerun_cpp/src/rerun/blueprint/components/root_container.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/space_view_class.hpp b/rerun_cpp/src/rerun/blueprint/components/space_view_class.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/space_view_maximized.hpp b/rerun_cpp/src/rerun/blueprint/components/space_view_maximized.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/space_view_origin.hpp b/rerun_cpp/src/rerun/blueprint/components/space_view_origin.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/viewer_recommendation_hash.hpp b/rerun_cpp/src/rerun/blueprint/components/viewer_recommendation_hash.hpp
diff --git a/rerun_cpp/src/rerun/blueprint/components/visible_time_range.hpp b/rerun_cpp/src/rerun/blueprint/components/visible_time_range.hpp
diff --git a/rerun_cpp/src/rerun/compiler_utils.hpp b/rerun_cpp/src/rerun/compiler_utils.hpp
@@ -52,12 +52,3 @@
 #else
 #define RR_DISABLE_DEPRECATION_WARNING
 #endif
-
-// Disable ASAN.
-#if defined(__GNUC__) || defined(__clang__)
-#define RR_DISABLE_ASAN __attribute__((no_sanitize("address")))
-#elif defined(_MSC_VER)
-#define RR_DISABLE_ASAN __declspec(no_sanitize_address)
-#else
-#define RR_DISABLE_ASAN
-#endif
diff --git a/rerun_cpp/src/rerun/components/class_id.hpp b/rerun_cpp/src/rerun/components/class_id.hpp
diff --git a/rerun_cpp/src/rerun/components/color.hpp b/rerun_cpp/src/rerun/components/color.hpp
diff --git a/rerun_cpp/src/rerun/components/half_sizes2d.hpp b/rerun_cpp/src/rerun/components/half_sizes2d.hpp
diff --git a/rerun_cpp/src/rerun/components/half_sizes3d.hpp b/rerun_cpp/src/rerun/components/half_sizes3d.hpp
diff --git a/rerun_cpp/src/rerun/components/keypoint_id.hpp b/rerun_cpp/src/rerun/components/keypoint_id.hpp
diff --git a/rerun_cpp/src/rerun/components/material.hpp b/rerun_cpp/src/rerun/components/material.hpp
diff --git a/rerun_cpp/src/rerun/components/media_type.hpp b/rerun_cpp/src/rerun/components/media_type.hpp
diff --git a/rerun_cpp/src/rerun/components/mesh_properties.hpp b/rerun_cpp/src/rerun/components/mesh_properties.hpp
diff --git a/rerun_cpp/src/rerun/components/name.hpp b/rerun_cpp/src/rerun/components/name.hpp