-
Notifications
You must be signed in to change notification settings - Fork 1
Toggle view-states without holding down keys #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI is red on |
Hmm, I'm not convinced that this is better. To me it just doesn't feel as good, but maybe I'm just used to the other controls now. Also it's not possible anymore to see just the old or new image with the diff overlayed. |
It's not about how much work it is as much as about about how intuitive it is. Before:
After:
100%
…but I can also add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The most important thing for me is to easily be able to toggle between old/new in a flip-book like fashion. Previously that required holding down a key, which was annoying. Now you can press 2, then 3, then back to 2, etc. Easy. Clean. I think also the new UI is more self-explanatory, using radio buttons instead of checkboxes.
Let me know if I broke some existing workflow.