Wire up source maps from transpiled modules to the bundle source map#1011
Open
prantlf wants to merge 3 commits intorequirejs:masterfrom
Open
Wire up source maps from transpiled modules to the bundle source map#1011prantlf wants to merge 3 commits intorequirejs:masterfrom
prantlf wants to merge 3 commits intorequirejs:masterfrom
Conversation
…e map * Depend on source-map-url to detect and remove a source map. * Depend on source-map -resolve to extract and decode a source map. * Ensure a semicolon at the end of a single module in front of the inline source map. * If a plugin transpiles a script, do not add the transpiled script with the name <path>!<plugin> to the source maps; add the original source under the original name. * Remove the code sections enclosed by excluding pragmas before the single module is appended to the output bundle to ensure proper offset for the line shifts. * Do not wrap single modules with extra leading and trailing line breaks. Put an extra line break between a pair of single modules when appending the to the output bundle. * If a single module contains an inline source map, apply it to the offsetting source map, when appending the module to the output bundle.
Use one code for wiring up source maps from uglified and not uglified modules.
* Use an absolute path instead of a path relative to baseUrl. The source map package understands the relative paths relative to the process current directory. * The name of the synchronous file-reading method in r.js file system facade is readFile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix #470.
If a single module source contains an inline source map, this source map will be wired up to the source map of the output bundle, so that the original source code will be available for debugging. Works for both optimisation settings -
noneanduglify2.! to the source maps; add the original source under the original name.
appended to the output bundle to ensure proper offset for the line shifts.
line break between a pair of single modules when appending the to the output bundle.
map, when appending the module to the output bundle.