[#57] Better Exception Handling #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han-gyeol
force-pushed
the
57-better-exception-handling
branch
from
6943465 to
6f81e46
Compare
|
@han-gyeol Is this WIP or ready for review? |
|
It's still WIP. Trying to figure out the test failure. |
|
@han-gyeol Any updates on this PR? |
|
Closing due to inactivity, @han-gyeol let me know if you wish to work on this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57
Add GitCheckerException for better debuggability. Currently when any of the git command fails, it simply throws RuntimeException without telling which specific command failed.
As mentioned in #442, this part of the code will be deprecated to better alternatives, but I still think each git operation deserves exception of its own for better clarity.
There is still a concern whether checked exception is necessary for git failure. If it is unnecessary, then maybe continue using RuntimeException is fine.