Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply SRP to various git commands #310 #408

Merged
merged 29 commits into from
Dec 22, 2018
Merged

Apply SRP to various git commands #310 #408

merged 29 commits into from
Dec 22, 2018

Conversation

eugenepeh
Copy link
Member

@eugenepeh eugenepeh commented Dec 8, 2018

part of #310

All the git commands are embedded in the CommandRunner class.

This violates the Single Responsibility Principle as CommandRunner
should only be responsible for the execution, and not the type of
commands.

As a step towards deprecating the use of CommandRunner, let's export
the commands to respective classes and remove the direct dependency on
CommandRunner.

@eugenepeh eugenepeh changed the title Apply SRP to various git commands Apply SRP to various git commands #310 Dec 18, 2018
Copy link
Contributor

@yong24s yong24s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits on inconsistency with use of static imports.

Copy link
Contributor

@yamidark yamidark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and nits

@eugenepeh
Copy link
Member Author

@yamidark @yong24s , thanks for the review!

Have fixed accordingly, ready for next iteration.

Copy link
Contributor

@yamidark yamidark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments.
Need to update the DeveloperGuide diagram from GitDownloader -> GitClone (as well as the Git section)

@eugenepeh
Copy link
Member Author

@yamidark thanks for the indepth review again, have made the changes.

@yamidark yamidark requested a review from yong24s December 20, 2018 15:26
@yong24s yong24s requested a review from damithc December 22, 2018 05:43
@eugenepeh eugenepeh merged commit dda7534 into reposense:master Dec 22, 2018
@eugenepeh eugenepeh deleted the system branch December 22, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants