Skip to content

Add ability to provide pre-defined secret for service-api and service-authorization #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add ability to provide pre-defined secret for service-api and service-authorization #470

wants to merge 5 commits into from

Conversation

ian-pascoe
Copy link

Addresses: #469

raikbitters
raikbitters reviewed May 15, 2025
View reviewed changes
Copy link
Member

@raikbitters raikbitters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like naming serviceapi-user-supplied-secret. Add more specific prefix like reportportal or return template name.

@ian-pascoe
Copy link
Author

I don't like naming serviceapi-user-supplied-secret. Add more specific prefix like reportportal or return template name.

The prefix reportportal prefix is added via some of the string interpolation included

@ian-pascoe
Copy link
Author

I don't like naming serviceapi-user-supplied-secret. Add more specific prefix like reportportal or return template name.

The prefix reportportal prefix is added via some of the string interpolation included

Ah Nevermind, I see the volume mounts are not named that way, I will add the prefix to those as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raikbitters raikbitters raikbitters left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-pascoe @raikbitters