Add VSCode extension repos #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
force-pushed
the
add-vscode-repos
branch
from
f012a4f
to
f60ec5d
Compare
Pandapip1
force-pushed
the
add-vscode-repos
branch
6 times, most recently
from
e4846cf
to
857e61e
Compare
|
I haven't tested this; I'm not sure if there are any steps I'm missing (maybe some unit and integration tests?). |
Pandapip1
force-pushed
the
add-vscode-repos
branch
from
857e61e
to
6a2670a
Compare
AMDmi3
requested changes
Sep 12, 2024
| class OpenVSXParser(Parser): | ||
| def iter_parse(self, path: str, factory: PackageFactory) -> Iterable[PackageMaker]: | ||
| with open(path, 'r') as extdatafile: | ||
| extension_data = json.load(extdatafile) |
There was a problem hiding this comment.
Loading json into memory is not scalable. You should use iter_json_list to parse it as stream.
| # TODO: More metadata is available, it's just harder to fetch and will require its own fetcher, in all likelihood | ||
| pkg.add_name('vscode-extension:{namespace}-{name}'.format(**extension), NameType.GENERIC_SRC_NAME) | ||
| pkg.set_version(extension['version']) | ||
| pkg.set_summary(extension['description']) |
There was a problem hiding this comment.
Description turns out to be optional, thus extension.get('description')
| for extension in raw_extensions: | ||
| with factory.begin() as pkg: | ||
| # TODO: More metadata is available, it's just harder to fetch and will require its own fetcher, in all likelihood | ||
| pkg.add_name('vscode-extension:{namespace}-{name}'.format(**extension), NameType.GENERIC_SRC_NAME) |
There was a problem hiding this comment.
vscode-extension: prefix should be added in a ruleset (and we can shorten it to vscode:). Also please use f-strings with defined fields.
| pkg.set_version(extension['version']) | ||
| pkg.set_summary(extension['description']) | ||
| pkg.add_maintainers('{namespace}@openvsx'.format(**extension)) | ||
| pkg.add_links(LinkType.UPSTREAM_HOMEPAGE, 'https://open-vsx.org/extension/{namespace}/{name}'.format(**extension)) |
There was a problem hiding this comment.
- f-strings with explicit extension fields here and around
- generated links are defined in
packagelinkssection of repo config. You can pass namespace/name throughpkg.extrafields - link type would be PROJECT_HOMEPAGE, it's not upstream
| if len(response['results'][0]['extensions']) < self.page_size: | ||
| break | ||
|
|
||
| with open(statefile.get_path(), 'w', encoding='utf-8') as extdata: |
There was a problem hiding this comment.
You write directly into statefile.get_file() here
AMDmi3
added a commit
to repology/repology-rules
that referenced
this pull request
Sep 23, 2024
|
Timeout. I've polished and merged openvsx support, vscmarketplace doesn't look suitable. Feel free to redo in compatible way if possible. |
AMDmi3
added a commit
that referenced
this pull request
Sep 23, 2024
- Fix parser to use standard json processing facility - Fix handling optional fields (download, description - Fix package link types and add another link (recipe/manifest) - Improbe name handling, handle display name properly - Move repository entry into modules/ fix type, update minpackages, enable shadow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.