Skip to content

Commit

Permalink
Disable scoop until proper QA and json validation is introduced
Browse files Browse the repository at this point in the history
  • Loading branch information
AMDmi3 committed Dec 11, 2023
1 parent 2483e74 commit 48f3d4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion repos.d/windows/scoop.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@
url: https://github.com/ScoopInstaller/Versions
- desc: Games repository on GitHub
url: https://github.com/Calinou/scoop-games
groups: [ all, production ]
groups: [ all ] # no proper qa, regularly broken json

5 comments on commit 48f3d4c

@mikaello
Copy link

@mikaello mikaello commented on 48f3d4c Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMDmi3 : Shouldn't this have been mentioned in https://repology.org/news ? It took some time to find that this was intentionally disabled, and it went under our radar for quite some time.

@AMDmi3
Copy link
Member Author

@AMDmi3 AMDmi3 commented on 48f3d4c Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I would like not to pollute news with flapping repositories updates.

BTW, I've commented here.

@mikaello
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It would nevertheless have been nice with some sort of reference to this other than this commit, I was initially looking for an issue or MR (after first looking at the news and history log for the dependency I was interested in), a standalone commit like this is not that obvious.

@chawyehsu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMDmi3 @mikaello Sorry to bother but as ScoopInstaller/GithubActions#39 getting merged, json format validation is now enabled for all incoming PRs for Scoop official buckets.

@AMDmi3
Copy link
Member Author

@AMDmi3 AMDmi3 commented on 48f3d4c Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoop enabled, thanks for heads up!

Please sign in to comment.