Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font:raleway version mess #52

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Conversation

alerque
Copy link
Contributor

@alerque alerque commented Aug 3, 2018

This font is a mess because the upstream sources are all over the place.
Each new version seems to show up on a different distribution channel,
usually without a version number or source code, and people have been
just guessing what they are. There are several upstream source
repositories posted by different people that have worked on the family
but they don't even all match each other.

The most coherent clues come from the changelog posted at Google Fonts:

https://github.com/google/fonts/blob/master/ofl/raleway/FONTLOG.txt

There it is clear that some version scheme has been attempted. The
personal sandbox of one of the designers also suggests the version
3.x being the last official release.

https://github.com/impallari/Raleway

There he also has some ongoing development work tagged as 4.x, but as of
yet it is incomplete and considered unreleased.

This tries to straighten the version scheme processing so snapshots are
ignored, devel versions are so tagged, and the 1.x, 2.x and 3.x releases
are actually assumed to be correct.

Note also Raleway Dots is a separate font with a different upstream
release cycle not actually versioned along with Raleway.

@AMDmi3
Copy link
Member

AMDmi3 commented Aug 3, 2018

Great work, thanks!

Let's just simplify this a bit by not taking nix version 2016-08-30 into account - there's global rule which handles these. E.g. ".*20[-0-9]{6,8}"".*20[0-9]{6}". Also you could use snapshot instead of ignore. It's the same thing, but with less vague name (see #43).

This font is a mess because the upstream sources are all over the place.
Each new version seems to show up on a different distribution channel,
usually without a version number or source code, and people have been
just guessing what they are. There are several upstream source
repositories posted by different people that have worked on the family
but they don't even all match each other.

The most coherent clues come from the changelog posted at Google Fonts:

https://github.com/google/fonts/blob/master/ofl/raleway/FONTLOG.txt

There it is clear that some version scheme has been attempted. The
personal sandbox of one of the designers also suggests the version
3.x being the last official release.

https://github.com/impallari/Raleway

There he also has some ongoing development work tagged as 4.x, but as of
yet it is incomplete and considered unreleased.

This tries to straighten the version scheme processing so snapshots are
ignored, devel versions are so tagged, and the 1.x, 2.x and 3.x releases
are actually assumed to be correct.

Note also Raleway Dots is a separate font with a different upstream
release cycle not actually versioned along with Raleway.
@alerque
Copy link
Contributor Author

alerque commented Aug 4, 2018

Simplified as suggested.

@AMDmi3 AMDmi3 merged commit 50fdbce into repology:master Aug 4, 2018
@alerque alerque deleted the fonts-raleway branch August 4, 2018 08:57
@alerque
Copy link
Contributor Author

alerque commented Aug 4, 2018

Catching the delimited dates (2016-08-3020160830) is nice, but what about when upstream authors forget a leading zero in a dated snapshot number? Such is the hapless case for fonts:raleway which one chap packaged as 0.0.2016830. Should I fix this specific instance somehow or is there a generic way of handling such slip ups?

@AMDmi3
Copy link
Member

AMDmi3 commented Aug 5, 2018

This is a rather special case so it makes sense to have an individual rule for it.

@alerque alerque mentioned this pull request Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants