Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Issues for Axis and Legend #33

Merged
merged 4 commits into from
Feb 12, 2018
Merged

Address Issues for Axis and Legend #33

merged 4 commits into from
Feb 12, 2018

Conversation

alisaono
Copy link
Member

60b43e0 and 810fe9c address replot/replot-bar#16:

  • Vertically centered Y-title.

BEFORE

ytitle_before

AFTER

ytitle_after

fb3ed5b addresses replot/replot-bar#18:

  • Increase padding for X-labels when X-title is hidden.

BEFORE

xlabels_before

AFTER

xlabels_after

810fe9c addresses replot/replot-bar#17 (when combined with the change made in replot-bar):

  • Hide the last Y-tick/label/gridline.

BEFORE

headspace_before

AFTER

headspace_after

d6228a4 addresses #31:
  • Add fontSize prop. Also add PropType for fontFamily prop.

DEFAULT

default

fontSize=12

fontsize_12

fontFamily="cursive"

fontfamily_cursive

@sanjaypojo @AlmahaAlmalki

@alisaono alisaono mentioned this pull request Feb 12, 2018
Merged
sanjaypojo
sanjaypojo approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@sanjaypojo sanjaypojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @alisaono 💯 Awesome stuff!

@sanjaypojo sanjaypojo merged commit 7ca72d0 into master Feb 12, 2018
@sanjaypojo sanjaypojo deleted the 021118 branch February 12, 2018 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaypojo sanjaypojo sanjaypojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisaono @sanjaypojo