Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update style props, example #10

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Update style props, example #10

merged 1 commit into from
Mar 9, 2018

Conversation

alisaono
Copy link
Member

@alisaono alisaono commented Mar 9, 2018

Addresses #9

  • Updated style props
  • Updated example with updated style props
  • Remove defaults for axis style props. These should be set in replot-core.

TODO:

  • Legend not implemented
  • README needs to be updated

@sanjaypojo @AlmahaAlmalki

sanjaypojo
sanjaypojo approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@sanjaypojo sanjaypojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sanjaypojo sanjaypojo merged commit aa60463 into master Mar 9, 2018
@sanjaypojo sanjaypojo deleted the update_030818 branch March 9, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaypojo sanjaypojo sanjaypojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alisaono @sanjaypojo