Replace timeout-based throttling with proper channel backpressure#761
Open
mokshasoft wants to merge 1 commit intoreplikativ:mainfrom
Open
Replace timeout-based throttling with proper channel backpressure#761mokshasoft wants to merge 1 commit intoreplikativ:mainfrom
mokshasoft wants to merge 1 commit intoreplikativ:mainfrom
Conversation
Use >! (blocking put) instead of put! combined with timeout sleeping. This provides proper backpressure semantics - the go-loop naturally parks when the commit queue buffer is full, instead of using an artificial 50ms sleep as a throttle. This removes one use of core.async/timeout which helps with GraalVM native-image compatibility (timeout creates a daemon thread).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use >! (blocking put) instead of put! combined with timeout sleeping. This provides proper backpressure semantics - the go-loop naturally parks when the commit queue buffer is full, instead of using an artificial 50ms sleep as a throttle.
This removes one use of core.async/timeout which helps with GraalVM native-image compatibility (timeout creates a daemon thread).
SUMMARY
Checks
Bugfix
fixes #numberFeature
fixes #numberADDITIONAL INFORMATION