Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: spec profile #606

Merged
merged 6 commits into from
Mar 3, 2023
Merged

test: spec profile #606

merged 6 commits into from
Mar 3, 2023

Conversation

jsmassa
Copy link
Collaborator

@jsmassa jsmassa commented Feb 27, 2023

SUMMARY

Follow-up for #596

Introduces kaocha profile that can run with specs enabled

@jsmassa jsmassa self-assigned this Feb 27, 2023
@jsmassa jsmassa marked this pull request as ready for review February 27, 2023 21:19
@jsmassa jsmassa requested a review from whilo February 27, 2023 21:19
@jsmassa jsmassa requested a review from TimoKramer March 3, 2023 00:59
@jsmassa jsmassa changed the title Spec testing profile test: spec profile Mar 3, 2023
Copy link
Member

@whilo whilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for factorizing it this way, I really like that the specs can be turned off from the outside for all tests!

@jsmassa jsmassa merged commit c098375 into main Mar 3, 2023
@jsmassa jsmassa deleted the spec-testing-profile branch March 3, 2023 14:12
whilo pushed a commit that referenced this pull request Mar 5, 2023
* Fix java warning

* Introduce kaocha profile for specs with tests

* Add spec test to babashka

* Add spec test to ci pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants