feat: allow migrate from HelmChart v1beta1 to v1beta2 if Helm --take-ownership is set

[nvanthao]

What this PR does / why we need it:

We currently don't allow migration from existing Helm installation of v1beta1 with useHelmInstall: false to Helm v1beta2.

As Helm CLI will soon support --take-ownership flag, this will be possible.

This PR allows the application pull for Helm chart with same name in v1beta2, as long as there is --take-ownership flag in Helm additional upgrade flags.

Demo: https://www.loom.com/share/db17e620509843d884fbcf98605daaed?t=281

If no --take-ownership flag, pull will fail during update checks

Which issue(s) this PR fixes:

Story: sc-117029

Does this PR require a test?

NONE

Does this PR require a release note?

NONE

We will need a release note later when upstream Helm CLI supports --take-ownership flag.

Does this PR require documentation?

Current docs will have to be updated after the change is merged and upstream Helm CLI supports --take-ownership flag

• https://docs.replicated.com/vendor/helm-v2-migrate#usehelminstall-false-limitation
• https://docs.replicated.com/reference/custom-resource-helmchart#usehelminstall

[xavpaice]

This needs to be merged alongside updating Helm to either use the version with --take-ownership merged and released, or our fork of it that does.

[nvanthao]

I've updated the PR with fetching from Helm PR that supports --take-ownership and build it.

[nvanthao]

Many thanks @sgalsaleh! I have made the requested changes accordingly and notice the Melange and Apko actions completed successfully. Please let me know how it goes.

[xavpaice]

Now that the change is merged in Helm, we can use the 'main' branch rather than the PR branch

[nvanthao]

Helm main branch is for their v4 and the "main" for current change is dev-v3

[nvanthao]

apologies @sgalsaleh could you help me approve the change again? I removed the expected-commit because we are cloning Helm with depth 1 and the commit is gone with newer commits from Helm.

[scottrigby]

Update: The new --take-ownership flag for install and upgrade commands has landed in Helm! Released yesterday Helm v3.17.0. Congrats to everyone who worked on this 👏🎉

[CLAassistant]

All committers have signed the CLA.

[xavpaice]

needs update now that Helm got released.

[nvanthao]

Hi @sgalsaleh @laverya,

I have removed the Helm PR setup due to --take-ownership flag is now in release v3.17.0.

Could you help me with the final approval?

Cheers,

[xavpaice]

Thanks for the update. Needs KOTS team to review.

[sgalsaleh]

Product question: should we add the flag automatically for a more seamless migration?

[adamancini]

@xavpaice signed CLA

[ajp-io]

Product question: should we add the flag automatically for a more seamless migration?

How would we detect this? And can we deterministically detect it, or could the vendor intend something else. I always like making things easier, but if this migration is being heavily moderated by Replicated (like we're helping vendors make these changes and whatnot), then the steps are pretty clear and the risk of doing it automatically might not be necessary.

So I could go either way depending on whether we think that's really necessary.