Skip to content

Conversation

@screspod
Copy link
Member

@screspod screspod commented Oct 7, 2025

What this PR does / why we need it:

Add support for kubernetes 1.34
https://app.shortcut.com/replicated/story/129820/support-for-kubernetes-1-34

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

@screspod screspod requested a review from a team as a code owner October 7, 2025 18:11
version: latest
rook:
version: "1.17.x"
version: "1.18.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a 1.18.x for rook currently published as a kURL addon. I see 1.18.x available upstream, just not in our repo yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diamonwiggins I'm going to revert this to use 1.17.x. Looks like 1.18 is failing test grid #5758

Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment

@screspod screspod requested a review from diamonwiggins October 7, 2025 19:23
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@screspod screspod merged commit 877b061 into main Oct 7, 2025
7 checks passed
@screspod screspod deleted the screspod/sc-129820/support-for-kubernetes-1-34 branch October 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants