Skip to content

Commit

Permalink
Fix automated PRs manager detecting validate success branch protectio…
Browse files Browse the repository at this point in the history
…n job (#1375)
  • Loading branch information
sgalsaleh authored Oct 23, 2024
1 parent 8e756f6 commit d064d24
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/automated-prs-manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
# If all tests and required checks passed, approve and merge.
if gh run view "$run_id" --json jobs -q '.jobs[] | select(.name == "validate-success") | .conclusion' | grep -q "success"; then
if gh run view "$run_id" --json jobs -q '.jobs[] | select(.name == "Validate success") | .conclusion' | grep -q "success"; then
if gh pr checks "${{ matrix.pr.url }}" --required; then
echo "All tests and required checks passed. Approving and merging."
echo -e "LGTM :thumbsup: \n\nThis PR was automatically approved and merged by the [automated-prs-manager](https://github.com/replicatedhq/embedded-cluster/blob/main/.github/workflows/automated-prs-manager.yaml) GitHub action" > body.txt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ jobs:
# this job will validate that all the tests passed
# it is used for the github branch protection rule
validate-success:
name: Validate success
name: Validate success # this name is used by .github/workflows/automated-prs-manager.yaml
runs-on: ubuntu-20.04
needs:
- e2e
Expand Down

0 comments on commit d064d24

Please sign in to comment.