Fix PGET Expected Byte Check #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philandstuff
approved these changes
Dec 3, 2024
tempusfrangit
force-pushed
the
fix-pget-expected-byte-checker
branch
from
5f80b75 to
ab1ab9d
Compare
Good point. I'll verify that works and get an update. |
Tar files have padding. Verify the end of the file is null and only error if there is non-null or we haven't matched content-length from origin. This behavior is an artifact of multi-readers if the final multireader is potentially all null bytes. New test mimics observed behavior.
tempusfrangit
force-pushed
the
fix-pget-expected-byte-checker
branch
from
ab1ab9d to
1e8bc92
Compare
|
The only risk here is if someone creates a malicious tar with massive padding it could force an oomkill. I am generally ok with that trade off. |
philandstuff
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tar files have padding. Verify the end of the file is null and only error if there is non-null or we haven't matched content-length from origin.