Download inputs off the event consumer loop #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we download inputs (via URLPath's convert() method) in
_prepare_payload, in the main Worker event consumer loop. This is bad, because
downloading inputs is a blocking operation and we cannot process other events
while downloads are in progress.
This is a substantial restructuring:
requests and cancel requests from the http server are now processed directly.
predictions and downloading inputs.
rather than serially. I have hardcoded a maximum of 8 concurrent downloads
based on the ThreadPoolExecutor size. I picked this number arbitrarily.
on the prediction start executor, which in turn submits downloads on the input
download executor. Once all inputs are downloaded, we send the prediction
request to the child.
is much simpler.
loop, not the Worker ThreadPoolExecutor. (This is maybe not strictly correct,
as we're calling blocking i/o from an async event loop, but it's a local
Connection object and it's a tiny amount of data)