Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast build flag to cog #2086

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add fast build flag to cog #2086

merged 2 commits into from
Dec 10, 2024

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Dec 9, 2024

  • Add an experimental —x-flag to the commands to denote whether fast build/run/push is used.

@8W9aG
Add fast build flag to cog
a09d144 
* Add an experimental —x-flag to the commands to
denote whether fast build/run/push is used.
meatballhat
meatballhat approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming for the sake of leaving a breadcrumb:

This adds --x-fast as a no-op with some logging to confirm the code paths we want to hit are being hit in real usage.

pkg/cli/build.go
@@ -69,7 +71,7 @@ func buildCommand(cmd *cobra.Command, args []string) error {
return err
}

if err := image.Build(cfg, projectDir, imageName, buildSecrets, buildNoCache, buildSeparateWeights, buildUseCudaBaseImage, buildProgressOutput, buildSchemaFile, buildDockerfileFile, DetermineUseCogBaseImage(cmd), buildStrip, buildPrecompile); err != nil {
if err := image.Build(cfg, projectDir, imageName, buildSecrets, buildNoCache, buildSeparateWeights, buildUseCudaBaseImage, buildProgressOutput, buildSchemaFile, buildDockerfileFile, DetermineUseCogBaseImage(cmd), buildStrip, buildPrecompile, buildFast); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a new problem, but this signature is getting a bit unruly 😅 ; a TODO for later...

@8W9aG 8W9aG merged commit 7256462 into main Dec 10, 2024
19 checks passed
@8W9aG 8W9aG deleted the add-x-fast-flag] branch December 10, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatballhat meatballhat meatballhat approved these changes

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8W9aG @meatballhat