Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Torch Dependency Resolution #1952

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Sep 12, 2024

  • Use our compatibility matrix to automatically resolve the torch version if the torch version is
    blank but adjacent dependencies are defined.

  • Make torchaudio capable of determining CUDA version compatibility like torchvision

  • Rewrite dependency versions to align with resolved versions

  • Remove version modifiers, this is now satisfied by adding in extra index URLs to the requirements

  • Fixes: Resolve Torch to maximum compatible version #1951

@8W9aG 8W9aG requested a review from technillogue September 12, 2024 21:34
* Use our compatibility matrix to automatically
resolve the torch version if the torch version is
blank but adjacent dependencies are defined.
* Make torchaudio capable of determining CUDA
version compatibility like torchvision
* Rewrite dependency versions to align with
resolved versions
* Remove version modifiers, this is now satisfied
by adding in extra index URLs to the requirements
@philandstuff philandstuff force-pushed the add-torch-version-resolver branch from ecf7413 to c19dfdc Compare September 13, 2024 09:51
@philandstuff
Copy link
Contributor

Now that the tests run properly, that test_torch_version_resolution_with_torchvision test failure looks suspicious 👀

@8W9aG
Copy link
Contributor Author

8W9aG commented Sep 13, 2024

Now that the tests run properly, that test_torch_version_resolution_with_torchvision test failure looks suspicious 👀

Looks like we are hitting the timeout on integration tests, I will bump to 20

* We now have enough integration tests that this
is becoming an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Torch to maximum compatible version
2 participants